Review Request 118698: Use correct type for QDBusReply when calling Activate.
Aurélien Gâteau
agateau at kde.org
Fri Jun 13 13:48:10 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118698/#review59997
-----------------------------------------------------------
Ship it!
Ship It!
- Aurélien Gâteau
On June 12, 2014, 7 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118698/
> -----------------------------------------------------------
>
> (Updated June 12, 2014, 7 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kdbusaddons
>
>
> Description
> -------
>
> Activate method has a different signature from CommandLine there is no return value that should be used for the exit code.
>
> This fixes a warning when invoking a unique app multiple times with no arguments.
>
>
> Diffs
> -----
>
> src/kdbusservice.cpp 6c190da
>
> Diff: https://git.reviewboard.kde.org/r/118698/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David Edmundson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140613/acff3060/attachment.html>
More information about the Kde-frameworks-devel
mailing list