Review Request 118680: Reorder Tests
Thomas Braxton
kde.braxton at gmail.com
Thu Jun 12 22:53:49 UTC 2014
> On June 12, 2014, 10:07 a.m., Aleix Pol Gonzalez wrote:
> > autotests/CMakeLists.txt, line 53
> > <https://git.reviewboard.kde.org/r/118680/diff/1/?file=280375#file280375line53>
> >
> > Why did you need to create a separate call to ecm_add_test?
> >
> > If it's for the target_include_directories, you can still do it to an ecm_add_tests created target.
No, because it depends on KConfigUtils, so it should be after test_kconfigutils.
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118680/#review59855
-----------------------------------------------------------
On June 11, 2014, 11:04 p.m., Thomas Braxton wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118680/
> -----------------------------------------------------------
>
> (Updated June 11, 2014, 11:04 p.m.)
>
>
> Review request for KDE Frameworks and Matthew Dawson.
>
>
> Repository: kconfig
>
>
> Description
> -------
>
> Some tests are testing underlying components, these should be tested before testing the components that depend on them.
>
>
> Diffs
> -----
>
> autotests/CMakeLists.txt 02885e7101bfd4239d3fb64f2940cb80933570b7
>
> Diff: https://git.reviewboard.kde.org/r/118680/diff/
>
>
> Testing
> -------
>
> All tests still pass
>
>
> Thanks,
>
> Thomas Braxton
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140612/e3391484/attachment.html>
More information about the Kde-frameworks-devel
mailing list