Review Request 117974: Some more KArchive examples
Maarten De Meyer
de.meyer.maarten at gmail.com
Fri Jun 6 19:15:37 UTC 2014
> On May 12, 2014, 3:16 p.m., Kevin Ottens wrote:
> > examples/bzip2gzip/main.cpp, line 74
> > <https://git.reviewboard.kde.org/r/117974/diff/1/?file=271400#file271400line74>
> >
> > Maybe a better idea to use a loop to avoid the readAll? I know that's an example which needs to be kept simple, but that would be a bit more realistic to read a few bytes from the input and write them in the output to not load the memory.
>
> Alex Merry wrote:
> Any progress on this?
Sorry, both emails missed my inbox. Should read mailing list more often.
Thank you for reviewing and caring :)
- Maarten
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117974/#review57784
-----------------------------------------------------------
On June 6, 2014, 7:15 p.m., Maarten De Meyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117974/
> -----------------------------------------------------------
>
> (Updated June 6, 2014, 7:15 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: karchive
>
>
> Description
> -------
>
> 2 extra examples on how to use the KArchive framework. Together with the 2 we already have most of the basic usage is covered.
> unzipper: Shows how to extract files from an archive
> bzip2gzip: Example about KCompressionDevice
>
> They are BSD licensed because I consider that a good license for examples. I wouldn't mind changing to GPL.
> Please let me know how they could be improved.
> Readability, comments, variable naming, too simple?
>
>
> Diffs
> -----
>
> examples/bzip2gzip/CMakeLists.txt PRE-CREATION
> examples/bzip2gzip/main.cpp PRE-CREATION
> examples/unzipper/CMakeLists.txt PRE-CREATION
> examples/unzipper/main.cpp PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/117974/diff/
>
>
> Testing
> -------
>
> Builds and runs ok.
> Easy to read and comprehend. (imho)
>
>
> Thanks,
>
> Maarten De Meyer
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140606/a33e3290/attachment.html>
More information about the Kde-frameworks-devel
mailing list