Review Request 117974: Some more KArchive examples

[Maarten De Meyer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117974/
-----------------------------------------------------------

(Updated June 6, 2014, 7:15 p.m.)


Review request for KDE Frameworks.


Changes
-------

Don't read all data at once. More scalable with big files.
I was unsure about the amount of bytes we should read per loop. 512 is the magic number.


Repository: karchive


Description
-------

2 extra examples on how to use the KArchive framework. Together with the 2 we already have most of the basic usage is covered.
unzipper: Shows how to extract files from an archive
bzip2gzip: Example about KCompressionDevice

They are BSD licensed because I consider that a good license for examples. I wouldn't mind changing to GPL.
Please let me know how they could be improved.
Readability, comments, variable naming, too simple?


Diffs (updated)
-----

  examples/bzip2gzip/CMakeLists.txt PRE-CREATION 
  examples/bzip2gzip/main.cpp PRE-CREATION 
  examples/unzipper/CMakeLists.txt PRE-CREATION 
  examples/unzipper/main.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/117974/diff/


Testing
-------

Builds and runs ok.
Easy to read and comprehend. (imho)


Thanks,

Maarten De Meyer

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140606/6fd43082/attachment.html>