Review Request 118489: Change all occurrences of KDE_NO_DEPRECATED to an appropriate define.

[Matthew Dawson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118489/
-----------------------------------------------------------

Review request for KDE Frameworks.


Repository: kconfig


Description
-------

Change all occurrences of KDE_NO_DEPRECATED to an appropriate define.

Inline with the new defines used by Frameworks, remove the KDE_NO_DEPRECATED.

Also remove some deprecated virtuals when compiling without deprecated features.

Make sure there are no deprecated features left when deprecated features are
compiled out.

When compiling without deprecated features, make sure not to use them.

KEmailSettings was using deprecated entries when the enumerations for the
features were compiled out, which would fail to compile.  Thus, when compiling
without deprecated features don't read extra configuration entries.

Remove usages of deprecated virtuals, instead use their replacement.

Go through and rename uses of usrWriteConfig to usrSave.  The change should
invoke no behavioural differences.  Note that the kconfig_compiler has
changed to the new function as well.


Note that removing the deprecated virtuals does cause the non-deprecated headers and deprecated libraries to be binary incompatible.  Since you can't really do this I don't think its an issue.  Also, kdelibs4support (others may too, haven't checked) uses a similar pattern. 


Diffs
-----

  autotests/kconfig_compiler/test_signal.cpp.ref 58e73efd77614edc4a5bd54bc06fbc34ccff2342 
  autotests/kconfig_compiler/test_signal.h.ref 19b8b4005e543e9e660f3ea016853c7a689ac17d 
  autotests/kconfigtest.cpp 2b6de0d7d63df6aee69210aa09418628f0b8110a 
  src/core/kconfig.h d27eebe7c41cb433b1808882c53cbf7b4c870950 
  src/core/kconfig.cpp ea9746c001e235529a1cdd5865b9e1b5c129b56a 
  src/core/kconfiggroup.h 3c4bce8433e3c5d4cb2d9fdd111a43f04cf3c295 
  src/core/kconfiggroup.cpp 6f609baefec5beaf38fdfedd6d192b395e3f8acb 
  src/core/kcoreconfigskeleton.h bb9c1cf936b87e2456726a2bb3428be42558b39f 
  src/core/kcoreconfigskeleton.cpp f9c9f26876922bc8dbed20d050b09f09868550ce 
  src/core/kemailsettings.h 03249e5006b309a39ed4b16f85b86439cbbe96a6 
  src/core/kemailsettings.cpp 230c2aa4ba1db85ae401e126de705cdbfd5a4a55 
  src/gui/kconfigloader.h 36eb182fbf1c241a043566a13d7c6c123a6e455f 
  src/gui/kconfigloader.cpp 1dd9e7fc44a367165fedc2e7760c8b524ecd210e 
  src/kconfig_compiler/kconfig_compiler.cpp 28b151c579c2c40e118b3b738a1e6ac81e461b3e 

Diff: https://git.reviewboard.kde.org/r/118489/diff/


Testing
-------

Unit tests still pass, regardless of whether or not deprecated features are enabled.


Thanks,

Matthew Dawson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140603/15a5faca/attachment.html>