<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118489/">https://git.reviewboard.kde.org/r/118489/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Matthew Dawson.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kconfig
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Change all occurrences of KDE_NO_DEPRECATED to an appropriate define.
Inline with the new defines used by Frameworks, remove the KDE_NO_DEPRECATED.
Also remove some deprecated virtuals when compiling without deprecated features.
Make sure there are no deprecated features left when deprecated features are
compiled out.
When compiling without deprecated features, make sure not to use them.
KEmailSettings was using deprecated entries when the enumerations for the
features were compiled out, which would fail to compile. Thus, when compiling
without deprecated features don't read extra configuration entries.
Remove usages of deprecated virtuals, instead use their replacement.
Go through and rename uses of usrWriteConfig to usrSave. The change should
invoke no behavioural differences. Note that the kconfig_compiler has
changed to the new function as well.
Note that removing the deprecated virtuals does cause the non-deprecated headers and deprecated libraries to be binary incompatible. Since you can't really do this I don't think its an issue. Also, kdelibs4support (others may too, haven't checked) uses a similar pattern. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Unit tests still pass, regardless of whether or not deprecated features are enabled.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/kconfig_compiler/test_signal.cpp.ref <span style="color: grey">(58e73efd77614edc4a5bd54bc06fbc34ccff2342)</span></li>
<li>autotests/kconfig_compiler/test_signal.h.ref <span style="color: grey">(19b8b4005e543e9e660f3ea016853c7a689ac17d)</span></li>
<li>autotests/kconfigtest.cpp <span style="color: grey">(2b6de0d7d63df6aee69210aa09418628f0b8110a)</span></li>
<li>src/core/kconfig.h <span style="color: grey">(d27eebe7c41cb433b1808882c53cbf7b4c870950)</span></li>
<li>src/core/kconfig.cpp <span style="color: grey">(ea9746c001e235529a1cdd5865b9e1b5c129b56a)</span></li>
<li>src/core/kconfiggroup.h <span style="color: grey">(3c4bce8433e3c5d4cb2d9fdd111a43f04cf3c295)</span></li>
<li>src/core/kconfiggroup.cpp <span style="color: grey">(6f609baefec5beaf38fdfedd6d192b395e3f8acb)</span></li>
<li>src/core/kcoreconfigskeleton.h <span style="color: grey">(bb9c1cf936b87e2456726a2bb3428be42558b39f)</span></li>
<li>src/core/kcoreconfigskeleton.cpp <span style="color: grey">(f9c9f26876922bc8dbed20d050b09f09868550ce)</span></li>
<li>src/core/kemailsettings.h <span style="color: grey">(03249e5006b309a39ed4b16f85b86439cbbe96a6)</span></li>
<li>src/core/kemailsettings.cpp <span style="color: grey">(230c2aa4ba1db85ae401e126de705cdbfd5a4a55)</span></li>
<li>src/gui/kconfigloader.h <span style="color: grey">(36eb182fbf1c241a043566a13d7c6c123a6e455f)</span></li>
<li>src/gui/kconfigloader.cpp <span style="color: grey">(1dd9e7fc44a367165fedc2e7760c8b524ecd210e)</span></li>
<li>src/kconfig_compiler/kconfig_compiler.cpp <span style="color: grey">(28b151c579c2c40e118b3b738a1e6ac81e461b3e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118489/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>