Review Request 118234: [frameworksintegration] Ensure the xcb connection gets flushed before the event dispatcher blocks

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118234/#review58953
-----------------------------------------------------------

Ship it!


Given the only objection so far has been that maybe we should make it mandatory, I'm going to say ship it. Making it required later on is easy if that turns out to be the best thing to do.

- Alex Merry


On May 30, 2014, 6:15 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118234/
> -----------------------------------------------------------
> 
> (Updated May 30, 2014, 6:15 a.m.)
> 
> 
> Review request for KDE Frameworks and Àlex Fiestas.
> 
> 
> Bugs: 334858
>     https://bugs.kde.org/show_bug.cgi?id=334858
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> -------
> 
> Ensure the xcb connection gets flushed before the event dispatcher blocks
> 
> This is a workaround for Qt versions which do not yet have the change
> https://codereview.qt-project.org/85654
> 
> It is important to have this workaround as applications can get stalled
> when a framework uses xcb and doesn't flush the connection manually.
> 
> BUG: 334858
> 
> 
> Diffs
> -----
> 
>   src/platformtheme/main.cpp 21d9aa0864e1887f5efbe4a05d264968af6e7e73 
>   src/platformtheme/config-platformtheme.h.cmake PRE-CREATION 
>   src/platformtheme/CMakeLists.txt da77cf816fe5f63e8eb9277d5d81d957b89c7966 
> 
> Diff: https://git.reviewboard.kde.org/r/118234/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140602/0c3cb77c/attachment.html>