<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118234/">https://git.reviewboard.kde.org/r/118234/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Given the only objection so far has been that maybe we should make it mandatory, I'm going to say ship it. Making it required later on is easy if that turns out to be the best thing to do.</pre>
<br />
<p>- Alex Merry</p>
<br />
<p>On May 30th, 2014, 6:15 a.m. UTC, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and Àlex Fiestas.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated May 30, 2014, 6:15 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=334858">334858</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
frameworkintegration
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ensure the xcb connection gets flushed before the event dispatcher blocks
This is a workaround for Qt versions which do not yet have the change
https://codereview.qt-project.org/85654
It is important to have this workaround as applications can get stalled
when a framework uses xcb and doesn't flush the connection manually.
BUG: 334858</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/platformtheme/main.cpp <span style="color: grey">(21d9aa0864e1887f5efbe4a05d264968af6e7e73)</span></li>
<li>src/platformtheme/config-platformtheme.h.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/platformtheme/CMakeLists.txt <span style="color: grey">(da77cf816fe5f63e8eb9277d5d81d957b89c7966)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118234/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>