Review Request 119523: port TextField to QtControls

[Marco Martin]

> On July 28, 2014, 7:09 p.m., Kai Uwe Broulik wrote:
> > src/declarativeimports/plasmacomponents/qml/styles/TextFieldStyle.qml, line 52
> > <https://git.reviewboard.kde.org/r/119523/diff/1/?file=293986#file293986line52>
> >
> >     Can't you account for the clear button width here?

probably


> On July 28, 2014, 7:09 p.m., Kai Uwe Broulik wrote:
> > src/declarativeimports/plasmacomponents/qml/styles/TextFieldStyle.qml, line 49
> > <https://git.reviewboard.kde.org/r/119523/diff/1/?file=293986#file293986line49>
> >
> >     Why no binding?

I can't access the framesvg from the level of the root.
could probably use a Binding {} tough


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119523/#review63367
-----------------------------------------------------------


On July 28, 2014, 6:10 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119523/
> -----------------------------------------------------------
> 
> (Updated July 28, 2014, 6:10 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> this ports TextField to Qt Controls.
> 
> Not sure if is really meargeable tough, because the old one used to export several properties and functions more, but they are not possible anymore, because in order for them to work is needed the access to the internal TextInput, and we don't have that, so some api should have to be dropped, breaking the compatibility promise.
> (another option would be to still use an own implementation, but use a compatible style anyways)
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/plasmacomponents/qml/TextField.qml 5bc6b58 
>   src/declarativeimports/plasmacomponents/qml/styles/TextFieldStyle.qml PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119523/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140728/8e366ba2/attachment-0001.html>