Review Request 119523: port TextField to QtControls

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119523/#review63367
-----------------------------------------------------------



src/declarativeimports/plasmacomponents/qml/styles/TextFieldStyle.qml
<https://git.reviewboard.kde.org/r/119523/#comment44168>

    Why no binding?



src/declarativeimports/plasmacomponents/qml/styles/TextFieldStyle.qml
<https://git.reviewboard.kde.org/r/119523/#comment44169>

    Can't you account for the clear button width here?


- Kai Uwe Broulik


On Juli 28, 2014, 6:10 nachm., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119523/
> -----------------------------------------------------------
> 
> (Updated Juli 28, 2014, 6:10 nachm.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> this ports TextField to Qt Controls.
> 
> Not sure if is really meargeable tough, because the old one used to export several properties and functions more, but they are not possible anymore, because in order for them to work is needed the access to the internal TextInput, and we don't have that, so some api should have to be dropped, breaking the compatibility promise.
> (another option would be to still use an own implementation, but use a compatible style anyways)
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/plasmacomponents/qml/TextField.qml 5bc6b58 
>   src/declarativeimports/plasmacomponents/qml/styles/TextFieldStyle.qml PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119523/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140728/111b2fe3/attachment.html>