Review Request 119321: kio-extras: Install KIO and KDED modules into correct folders

[Dan Vrátil]

> On July 16, 2014, 8:21 p.m., Alexander Richardson wrote:
> > The kioslaves part seems to be more or less like my patch here: https://git.reviewboard.kde.org/r/119081/ , just without the renaming of the output file.

OOoops, sorry,  I didn't check for previous reviews. And also assigned a wrong review group :) 

I'll abandon this review, since yours was here first. Feel free to pickup the renameing part of the patch if you want to.


- Dan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119321/#review62522
-----------------------------------------------------------


On July 16, 2014, 5:20 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119321/
> -----------------------------------------------------------
> 
> (Updated July 16, 2014, 5:20 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kio-extras
> 
> 
> Description
> -------
> 
> The KIO Frameworks installs the ioslaves into ```${PLUGIN_INSTALL_DIR}/kf5/kio```, so kio-extras should follow. This patch also drops the ```kio_``` prefix from the binary name - it made sense when all the libraries were in /usr/lib, but does not make sense when they have their own folder now (also the ones installed by KIO Framework don't have the prefix)
> 
> Same for KDED modules and KParts installed by kio-extras: KDED Framework installs KDED modules to ```${PLUGIN_INSTALL_DIR}/kf5/kded``` and binaries don't have the ```kded_``` prefix, KParts are installed to ```${PLUGIN_INSTALL_DIR}/kf5/parts```.
> 
> 
> Diffs
> -----
> 
>   desktop/CMakeLists.txt f7bd670 
>   recentdocuments/recentdocuments.protocol c0bf1eb 
>   desktop/desktopnotifier.desktop a32ee6f 
>   filter/CMakeLists.txt 240cc7b 
>   filter/bzip.protocol 7d3cb57 
>   filter/bzip2.protocol 1baaf7d 
>   filter/gzip.protocol 8ed55ec 
>   filter/lzma.protocol 13bb28e 
>   filter/xz.protocol f4fb7f0 
>   fish/CMakeLists.txt 24136d4 
>   fish/fish.protocol ff5784e 
>   info/CMakeLists.txt 0163e82 
>   info/info.protocol fa8cbb4 
>   man/CMakeLists.txt 3343ed8 
>   man/kmanpart.desktop cc5df64 
>   man/man.protocol cc100ce 
>   network/ioslave/CMakeLists.txt 67fc482 
>   network/ioslave/network.protocol 1e10cc6 
>   network/kded/CMakeLists.txt 3be676e 
>   network/kded/networkwatcher.desktop f9fdce3 
>   nfs/CMakeLists.txt dfc6eae 
>   nfs/nfs.protocol 85cf203 
>   recentdocuments/CMakeLists.txt bc2b9db 
>   bookmarks/bookmarks.protocol 0642bd2 
>   archive/tar.protocol 19447a5 
>   archive/zip.protocol ce7c54b 
>   bookmarks/CMakeLists.txt 703b109 
>   archive/CMakeLists.txt ec2cf7a 
>   archive/ar.protocol 7a848e5 
>   recentdocuments/recentdocumentsnotifier.desktop 096b14b 
>   settings/CMakeLists.txt 5a57a18 
>   settings/settings.protocol efb03e8 
>   sftp/CMakeLists.txt defb7dd 
>   sftp/sftp.protocol ec15eeb 
>   smb/CMakeLists.txt a3a772f 
>   smb/smb.protocol e585978 
>   thumbnail/CMakeLists.txt f3733d4 
>   thumbnail/thumbnail.protocol eef743a 
>   trash/CMakeLists.txt 4ee0358 
>   trash/trash.protocol 2776985 
> 
> Diff: https://git.reviewboard.kde.org/r/119321/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140717/96afc8d6/attachment.html>