<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119321/">https://git.reviewboard.kde.org/r/119321/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 16th, 2014, 8:21 p.m. CEST, <b>Alexander Richardson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The kioslaves part seems to be more or less like my patch here: https://git.reviewboard.kde.org/r/119081/ , just without the renaming of the output file.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">OOoops, sorry, I didn't check for previous reviews. And also assigned a wrong review group :) </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'll abandon this review, since yours was here first. Feel free to pickup the renameing part of the patch if you want to.</p></pre>
<br />
<p>- Dan</p>
<br />
<p>On July 16th, 2014, 5:20 p.m. CEST, Dan Vrátil wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Dan Vrátil.</div>
<p style="color: grey;"><i>Updated July 16, 2014, 5:20 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kio-extras
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The KIO Frameworks installs the ioslaves into <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">${PLUGIN_INSTALL_DIR}/kf5/kio</code>, so kio-extras should follow. This patch also drops the <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">kio_</code> prefix from the binary name - it made sense when all the libraries were in /usr/lib, but does not make sense when they have their own folder now (also the ones installed by KIO Framework don't have the prefix)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Same for KDED modules and KParts installed by kio-extras: KDED Framework installs KDED modules to <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">${PLUGIN_INSTALL_DIR}/kf5/kded</code> and binaries don't have the <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">kded_</code> prefix, KParts are installed to <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">${PLUGIN_INSTALL_DIR}/kf5/parts</code>.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>desktop/CMakeLists.txt <span style="color: grey">(f7bd670)</span></li>
<li>recentdocuments/recentdocuments.protocol <span style="color: grey">(c0bf1eb)</span></li>
<li>desktop/desktopnotifier.desktop <span style="color: grey">(a32ee6f)</span></li>
<li>filter/CMakeLists.txt <span style="color: grey">(240cc7b)</span></li>
<li>filter/bzip.protocol <span style="color: grey">(7d3cb57)</span></li>
<li>filter/bzip2.protocol <span style="color: grey">(1baaf7d)</span></li>
<li>filter/gzip.protocol <span style="color: grey">(8ed55ec)</span></li>
<li>filter/lzma.protocol <span style="color: grey">(13bb28e)</span></li>
<li>filter/xz.protocol <span style="color: grey">(f4fb7f0)</span></li>
<li>fish/CMakeLists.txt <span style="color: grey">(24136d4)</span></li>
<li>fish/fish.protocol <span style="color: grey">(ff5784e)</span></li>
<li>info/CMakeLists.txt <span style="color: grey">(0163e82)</span></li>
<li>info/info.protocol <span style="color: grey">(fa8cbb4)</span></li>
<li>man/CMakeLists.txt <span style="color: grey">(3343ed8)</span></li>
<li>man/kmanpart.desktop <span style="color: grey">(cc5df64)</span></li>
<li>man/man.protocol <span style="color: grey">(cc100ce)</span></li>
<li>network/ioslave/CMakeLists.txt <span style="color: grey">(67fc482)</span></li>
<li>network/ioslave/network.protocol <span style="color: grey">(1e10cc6)</span></li>
<li>network/kded/CMakeLists.txt <span style="color: grey">(3be676e)</span></li>
<li>network/kded/networkwatcher.desktop <span style="color: grey">(f9fdce3)</span></li>
<li>nfs/CMakeLists.txt <span style="color: grey">(dfc6eae)</span></li>
<li>nfs/nfs.protocol <span style="color: grey">(85cf203)</span></li>
<li>recentdocuments/CMakeLists.txt <span style="color: grey">(bc2b9db)</span></li>
<li>bookmarks/bookmarks.protocol <span style="color: grey">(0642bd2)</span></li>
<li>archive/tar.protocol <span style="color: grey">(19447a5)</span></li>
<li>archive/zip.protocol <span style="color: grey">(ce7c54b)</span></li>
<li>bookmarks/CMakeLists.txt <span style="color: grey">(703b109)</span></li>
<li>archive/CMakeLists.txt <span style="color: grey">(ec2cf7a)</span></li>
<li>archive/ar.protocol <span style="color: grey">(7a848e5)</span></li>
<li>recentdocuments/recentdocumentsnotifier.desktop <span style="color: grey">(096b14b)</span></li>
<li>settings/CMakeLists.txt <span style="color: grey">(5a57a18)</span></li>
<li>settings/settings.protocol <span style="color: grey">(efb03e8)</span></li>
<li>sftp/CMakeLists.txt <span style="color: grey">(defb7dd)</span></li>
<li>sftp/sftp.protocol <span style="color: grey">(ec15eeb)</span></li>
<li>smb/CMakeLists.txt <span style="color: grey">(a3a772f)</span></li>
<li>smb/smb.protocol <span style="color: grey">(e585978)</span></li>
<li>thumbnail/CMakeLists.txt <span style="color: grey">(f3733d4)</span></li>
<li>thumbnail/thumbnail.protocol <span style="color: grey">(eef743a)</span></li>
<li>trash/CMakeLists.txt <span style="color: grey">(4ee0358)</span></li>
<li>trash/trash.protocol <span style="color: grey">(2776985)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119321/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>