Review Request 118263: Port polkit-kde-agent to KF5::KDELibs4Support and KF5::IconThemes

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118263/#review61531
-----------------------------------------------------------

Ship it!


What's the point of letting it compile against Qt4 and Qt5? Porting away frmn KDELibs4Support and trying to compile both Qt4 and Qt5 is not something we can do I'd say.

Anyway, I haven't spotted anything obvious, so if that helps you can get it in. I'm not proficient in that code-base.

- Aleix Pol Gonzalez


On July 3, 2014, 8:48 a.m., Martin Bříza wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118263/
> -----------------------------------------------------------
> 
> (Updated July 3, 2014, 8:48 a.m.)
> 
> 
> Review request for KDE Frameworks and Polkit KDE Agent.
> 
> 
> Repository: polkit-kde-agent-1
> 
> 
> Description
> -------
> 
> Use -DUSE_QT4=true to build against kdelibs4; -DUSE_QT5=true to build against KF5. Don't use anything to let cmake decide, with KF5 being a priority. 
> 
> Sorry for using KDELibs4Support - I tried to not do it but it required 8 frameworks and a massive rewrite.
> 
> 
> Diffs
> -----
> 
>   AuthDialog.h 620145d 
>   AuthDialog.cpp f2c4886 
>   CMakeLists.txt f79b88f 
>   main.cpp 33ef236 
>   policykitlistener.cpp 6da9461 
>   polkit-kde-authentication-agent-1.desktop.in aa088cc 
> 
> Diff: https://git.reviewboard.kde.org/r/118263/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Bříza
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140703/c33ec319/attachment.html>