<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118263/">https://git.reviewboard.kde.org/r/118263/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What's the point of letting it compile against Qt4 and Qt5? Porting away frmn KDELibs4Support and trying to compile both Qt4 and Qt5 is not something we can do I'd say.
Anyway, I haven't spotted anything obvious, so if that helps you can get it in. I'm not proficient in that code-base.</pre>
<br />
<p>- Aleix Pol Gonzalez</p>
<br />
<p>On July 3rd, 2014, 8:48 a.m. UTC, Martin Bříza wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and Polkit KDE Agent.</div>
<div>By Martin Bříza.</div>
<p style="color: grey;"><i>Updated July 3, 2014, 8:48 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
polkit-kde-agent-1
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Use -DUSE_QT4=true to build against kdelibs4; -DUSE_QT5=true to build against KF5. Don't use anything to let cmake decide, with KF5 being a priority.
Sorry for using KDELibs4Support - I tried to not do it but it required 8 frameworks and a massive rewrite.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>AuthDialog.h <span style="color: grey">(620145d)</span></li>
<li>AuthDialog.cpp <span style="color: grey">(f2c4886)</span></li>
<li>CMakeLists.txt <span style="color: grey">(f79b88f)</span></li>
<li>main.cpp <span style="color: grey">(33ef236)</span></li>
<li>policykitlistener.cpp <span style="color: grey">(6da9461)</span></li>
<li>polkit-kde-authentication-agent-1.desktop.in <span style="color: grey">(aa088cc)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118263/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>