Review Request 119079: Add utility function for loading all plugins from a given dir + easy accessor for metadata

[Alexander Richardson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119079/
-----------------------------------------------------------

(Updated July 2, 2014, 12:25 a.m.)


Review request for KDE Frameworks.


Summary (updated)
-----------------

Add utility function for loading all plugins from a given dir + easy accessor for metadata


Repository: kcoreaddons


Description (updated)
-------

This class simplifies reading the metadata from a qt plugin by providing
type safe accessor functions for the standard plugininfo keys that are
also used by the .desktop file based KPluginInfo

KPluginMetaData: Read the translated value for name and description

The "Name" and "Comment" fields of the metadata should be translated
since they will be shown to the user (e.g. in the plugin selection
dialog)

Add a unit test for KPluginMetaData


Add KPluginMetaData::findPlugins()


Add a unit test for KPluginMetaData::findPlugins()


Introduce KPluginLoader::instantiatePlugins() and add a unit test

This method allows easily instantiating all plugins in a given directory

KPluginMetaData::pluginName() was changed to return the base name of the
plugin file if no plugin name was set in the JSON metadata


Diffs (updated)
-----

  src/lib/plugin/kpluginmetadata.cpp PRE-CREATION 
  src/lib/plugin/kpluginmetadata.h PRE-CREATION 
  src/lib/plugin/kpluginloader.cpp 9b3c5b6aec537b03b0d8341b33f6f4d7a76c8344 
  src/lib/plugin/kpluginloader.h 0b7a53d3b879cec1d755b849d9d8c640d251a379 
  src/lib/CMakeLists.txt 26eb5a1d4d56742a3395ba2645290bea15aee181 
  autotests/kpluginmetadatatest.cpp PRE-CREATION 
  autotests/kpluginloadertest.cpp c8225c02de3a64cae29d88954700dbc6f03ff1b0 
  autotests/CMakeLists.txt 75d12932b36fcfe4ae1d538176ef9f85f60f15dd 

Diff: https://git.reviewboard.kde.org/r/119079/diff/


Testing
-------

Added a unit test

Should easily allow loading all plugins from a given directory without needing kbuildsycoca


Thanks,

Alexander Richardson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140701/28a8e9dc/attachment-0001.html>