<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119079/">https://git.reviewboard.kde.org/r/119079/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Alexander Richardson.</div>
<p style="color: grey;"><i>Updated July 2, 2014, 12:25 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Summary (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add utility function for loading all plugins from a given dir + easy accessor for metadata</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kcoreaddons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This class simplifies reading the metadata from a qt plugin by providing
type safe accessor functions for the standard plugininfo keys that are
also used by the .desktop file based KPluginInfo
KPluginMetaData: Read the translated value for name and description
The "Name" and "Comment" fields of the metadata should be translated
since they will be shown to the user (e.g. in the plugin selection
dialog)
Add a unit test for KPluginMetaData
Add KPluginMetaData::findPlugins()
Add a unit test for KPluginMetaData::findPlugins()
Introduce KPluginLoader::instantiatePlugins() and add a unit test
This method allows easily instantiating all plugins in a given directory
KPluginMetaData::pluginName() was changed to return the base name of the
plugin file if no plugin name was set in the JSON metadata</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Added a unit test
Should easily allow loading all plugins from a given directory without needing kbuildsycoca</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/plugin/kpluginmetadata.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/plugin/kpluginmetadata.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/plugin/kpluginloader.cpp <span style="color: grey">(9b3c5b6aec537b03b0d8341b33f6f4d7a76c8344)</span></li>
<li>src/lib/plugin/kpluginloader.h <span style="color: grey">(0b7a53d3b879cec1d755b849d9d8c640d251a379)</span></li>
<li>src/lib/CMakeLists.txt <span style="color: grey">(26eb5a1d4d56742a3395ba2645290bea15aee181)</span></li>
<li>autotests/kpluginmetadatatest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/kpluginloadertest.cpp <span style="color: grey">(c8225c02de3a64cae29d88954700dbc6f03ff1b0)</span></li>
<li>autotests/CMakeLists.txt <span style="color: grey">(75d12932b36fcfe4ae1d538176ef9f85f60f15dd)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119079/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>