Review Request 119058: add a test case for KIconLoader::addAppDir()

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119058/#review61423
-----------------------------------------------------------



autotests/kiconloader_unittest.cpp
<https://git.reviewboard.kde.org/r/119058/#comment42757>

    ok, can't change kiconloader that way due to the docu, so instead, clear the path before each call to loadIcon....
    
    otherwise you might be looking at an old value for it, if loadIcon failed.
    


- David Faure


On July 1, 2014, 6:28 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119058/
> -----------------------------------------------------------
> 
> (Updated July 1, 2014, 6:28 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kiconthemes
> 
> 
> Description
> -------
> 
> when the theme is not complete, KIconLoader::addAppDir may break the fallback to the default themeof icons to the default theme.
> this test case shhows the breakage.
> commenting out addAppDir() makes the test pass.
> 
> 
> Diffs
> -----
> 
>   autotests/CMakeLists.txt 798509d 
>   autotests/breeze.theme PRE-CREATION 
>   autotests/kiconloader_unittest.cpp d4ec842 
>   autotests/resources.qrc 33c2510 
> 
> Diff: https://git.reviewboard.kde.org/r/119058/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140701/61e74086/attachment.html>