Review Request 119058: add a test case for KIconLoader::addAppDir()

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119058/#review61419
-----------------------------------------------------------


Don't commit a test that fails, the CI being red makes everyone sad. (more seriously, it's rule number one of unittesting). Use QEXPECT_FAIL if you want to push a test that shows a failure.


autotests/kiconloader_unittest.cpp
<https://git.reviewboard.kde.org/r/119058/#comment42747>

    unneeded, remove



autotests/kiconloader_unittest.cpp
<https://git.reviewboard.kde.org/r/119058/#comment42748>

    "KDE" is a community, and isn't missing :)
    I guess this should say "kde.png" instead.



autotests/kiconloader_unittest.cpp
<https://git.reviewboard.kde.org/r/119058/#comment42749>

    This relies on loadIcon always modifing "path", whether it succeeds or not.
    
    But it doesn't, right now.
    https://git.reviewboard.kde.org/r/119076/



autotests/kiconloader_unittest.cpp
<https://git.reviewboard.kde.org/r/119058/#comment42750>

    not really, you're doing it on the same KIconLoader instance, so this is really addAppDir+reconfigure.
    
    My idea was different KIconLoader instances -- which would look a lot cleaner with a data-driven test...


- David Faure


On July 1, 2014, 6:28 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119058/
> -----------------------------------------------------------
> 
> (Updated July 1, 2014, 6:28 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kiconthemes
> 
> 
> Description
> -------
> 
> when the theme is not complete, KIconLoader::addAppDir may break the fallback to the default themeof icons to the default theme.
> this test case shhows the breakage.
> commenting out addAppDir() makes the test pass.
> 
> 
> Diffs
> -----
> 
>   autotests/CMakeLists.txt 798509d 
>   autotests/breeze.theme PRE-CREATION 
>   autotests/kiconloader_unittest.cpp d4ec842 
>   autotests/resources.qrc 33c2510 
> 
> Diff: https://git.reviewboard.kde.org/r/119058/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140701/095e2c01/attachment.html>