Review Request 115251: Add better runtime detection for X11 usage in KStartupInfo
Alex Merry
kde at randomguy3.me.uk
Fri Jan 31 20:45:43 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115251/#review48713
-----------------------------------------------------------
src/kstartupinfo.cpp
<https://git.reviewboard.kde.org/r/115251/#comment34393>
Surely we shouldn't be using KXMessages if we don't have X11?
(Also applies to the next bunch of methods)
src/kstartupinfo.cpp
<https://git.reviewboard.kde.org/r/115251/#comment34396>
Should this be under a test? Or does the HAVE_X11 need to be there at all?
src/kstartupinfo.cpp
<https://git.reviewboard.kde.org/r/115251/#comment34397>
Again, does this need HAVE_X11? netwm_def.h actually ends up being used on all platforms.
- Alex Merry
On Jan. 27, 2014, 7:31 a.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115251/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2014, 7:31 a.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kwindowsystem
>
>
> Description
> -------
>
> Add better runtime detection for X11 usage in KStartupInfo
>
> Compile time checks for X11 is no longer sufficient. This adds a
> runtime check to all the code paths which look dangerous if executed
> on a non-X11 platform.
>
>
> Diffs
> -----
>
> src/kstartupinfo.cpp 5dbf47cb666fbed17c943491efe93e17f27d581e
>
> Diff: https://git.reviewboard.kde.org/r/115251/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Gräßlin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140131/2c63e577/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list