Review Request 115251: Add better runtime detection for X11 usage in KStartupInfo

[Martin Gräßlin]

> On Jan. 30, 2014, 3:49 p.m., David Edmundson wrote:
> > src/kstartupinfo.cpp, line 1068
> > <https://git.reviewboard.kde.org/r/115251/diff/2/?file=240679#file240679line1068>
> >
> >     Does this need a runtime check?

no that should be fine. The Qt method delegates to nativeResourceForScreen in the QPlatformNativeInterface which should return 0 in case it doesn't exist.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115251/#review48622
-----------------------------------------------------------


On Jan. 27, 2014, 8:31 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115251/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2014, 8:31 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> -------
> 
> Add better runtime detection for X11 usage in KStartupInfo
> 
> Compile time checks for X11 is no longer sufficient. This adds a
> runtime check to all the code paths which look dangerous if executed
> on a non-X11 platform.
> 
> 
> Diffs
> -----
> 
>   src/kstartupinfo.cpp 5dbf47cb666fbed17c943491efe93e17f27d581e 
> 
> Diff: https://git.reviewboard.kde.org/r/115251/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140131/0c21d603/attachment.html>