Review Request 114990: removing kde4 references from kauth

Alex Merry kde at randomguy3.me.uk
Fri Jan 31 18:06:06 UTC 2014



> On Jan. 13, 2014, 12:09 p.m., Alex Merry wrote:
> > src/kauthactionreply.h, line 173
> > <https://git.reviewboard.kde.org/r/114990/diff/1/?file=233880#file233880line173>
> >
> >     I'm sure no such macro exists.  Have a look in kauth/cmake/KF5AuthMacros.cmake for what it should become.

Are you planning to update this request?  If not, could you discard it, please?


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114990/#review47310
-----------------------------------------------------------


On Jan. 12, 2014, 8:12 p.m., Siddharth Sharma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114990/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2014, 8:12 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kauth
> 
> 
> Description
> -------
> 
> removing kde4 references from kauth
> 
> 
> Diffs
> -----
> 
>   src/kauthactionreply.h a7d2020 
> 
> Diff: https://git.reviewboard.kde.org/r/114990/diff/
> 
> 
> Testing
> -------
> 
> none
> 
> 
> Thanks,
> 
> Siddharth Sharma
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140131/e54a5ac3/attachment.html>


More information about the Kde-frameworks-devel mailing list