Review Request 115411: Remove obsolete CMake code from pre-splitting
Alex Merry
kde at randomguy3.me.uk
Fri Jan 31 17:52:12 UTC 2014
On 31/01/14 15:39, Aleix Pol Gonzalez wrote:
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115411/
>
>
> Ship it!
>
> I think we should agree on doing this for all frameworks, actually.
>
> All this checking if it's being built out of kdelibs doesn't make sense anymore.
I think that's sensible. I did briefly wonder if maybe the check around
feature_summary should stay, but I don't think it makes any sense to
support building a framework as part of a large cmake project (there are
too many variables and paths and hacks required).
Alex
More information about the Kde-frameworks-devel
mailing list