Review Request 115411: Remove obsolete CMake code from pre-splitting

Aleix Pol Gonzalez aleixpol at kde.org
Fri Jan 31 15:39:25 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115411/#review48682
-----------------------------------------------------------

Ship it!


I think we should agree on doing this for all frameworks, actually.

All this checking if it's being built out of kdelibs doesn't make sense anymore.

- Aleix Pol Gonzalez


On Jan. 31, 2014, 12:03 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115411/
> -----------------------------------------------------------
> 
> (Updated Jan. 31, 2014, 12:03 p.m.)
> 
> 
> Review request for KDE Frameworks and Chusslove Illich.
> 
> 
> Repository: ki18n
> 
> 
> Description
> -------
> 
> Remove obsolete CMake code from pre-splitting
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt bf678c41b78ab984a5b30a278a21ceaeddeeccff 
> 
> Diff: https://git.reviewboard.kde.org/r/115411/diff/
> 
> 
> Testing
> -------
> 
> Builds fine.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140131/920fd994/attachment.html>


More information about the Kde-frameworks-devel mailing list