Review Request 115394: Split KCompletionBase from kcompletion.h
Aurélien Gâteau
agateau at kde.org
Fri Jan 31 14:32:05 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115394/#review48678
-----------------------------------------------------------
Ship it!
Had to redo the changes in kcompletion.h because of a conflict, but it works fine.
- Aurélien Gâteau
On Jan. 30, 2014, 11:59 p.m., David Gil Oliva wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115394/
> -----------------------------------------------------------
>
> (Updated Jan. 30, 2014, 11:59 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kcompletion
>
>
> Description
> -------
>
> To make kcompletion.h smaller, split KCompletionBase class from it into its own header file.
>
>
> Diffs
> -----
>
> src/klineedit.h f1107e2
> src/kcompletionbase.h PRE-CREATION
> src/kcompletionbase.cpp 252b613
> src/kcompletion.h fa0731e
> src/kcombobox.h f34d259
> src/CMakeLists.txt 05452ab
>
> Diff: https://git.reviewboard.kde.org/r/115394/diff/
>
>
> Testing
> -------
>
> It builds. Tests pass.
>
>
> Thanks,
>
> David Gil Oliva
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140131/7891ae88/attachment.html>
More information about the Kde-frameworks-devel
mailing list