Review Request 115394: Split KCompletionBase from kcompletion.h

[David Gil Oliva]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115394/
-----------------------------------------------------------

(Updated Jan. 30, 2014, 10:59 p.m.)


Review request for KDE Frameworks.


Changes
-------

Fix issues noted by Aurélien Gâteau


Repository: kcompletion


Description
-------

To make kcompletion.h smaller, split KCompletionBase class from it into its own header file.


Diffs (updated)
-----

  src/klineedit.h f1107e2 
  src/kcompletionbase.h PRE-CREATION 
  src/kcompletionbase.cpp 252b613 
  src/kcompletion.h fa0731e 
  src/kcombobox.h f34d259 
  src/CMakeLists.txt 05452ab 

Diff: https://git.reviewboard.kde.org/r/115394/diff/


Testing
-------

It builds. Tests pass.


Thanks,

David Gil Oliva

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140130/69392344/attachment.html>