Review Request 115404: Improve dependencies

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115404/#review48675
-----------------------------------------------------------

Ship it!


Checked with CMake 2.8.12.0 - still works fine.

- Alex Merry


On Jan. 30, 2014, 5:32 p.m., Michael Palimaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115404/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2014, 5:32 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kemoticons
> 
> 
> Description
> -------
> 
> - Remove transitive dependencies as per mailing list
> - Add missing KF5Config dependency
> - QtGui is used rather than QtWidgets by the framework.
> - QtWidgets is only used for tests
> 
> 
> Diffs
> -----
> 
>   tests/CMakeLists.txt a3016c172f18559a98771c9d7da53cfdc758adad 
>   src/core/CMakeLists.txt 9bc9a1c1a995f488185dfd19ef25bcc1f9e8a483 
>   KF5EmoticonsConfig.cmake.in 9b0efbc99cfed73c13e49c940cd5607afba85f07 
>   CMakeLists.txt a48d111c59aa42d5b0b85aa959e5cf10e7b974b0 
> 
> Diff: https://git.reviewboard.kde.org/r/115404/diff/
> 
> 
> Testing
> -------
> 
> Builds. Inspected source to verify changes.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140131/628de76b/attachment-0001.html>