<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115404/">https://git.reviewboard.kde.org/r/115404/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Checked with CMake 2.8.12.0 - still works fine.</pre>
<br />
<p>- Alex Merry</p>
<br />
<p>On January 30th, 2014, 5:32 p.m. UTC, Michael Palimaka wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Michael Palimaka.</div>
<p style="color: grey;"><i>Updated Jan. 30, 2014, 5:32 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kemoticons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">- Remove transitive dependencies as per mailing list
- Add missing KF5Config dependency
- QtGui is used rather than QtWidgets by the framework.
- QtWidgets is only used for tests
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds. Inspected source to verify changes.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tests/CMakeLists.txt <span style="color: grey">(a3016c172f18559a98771c9d7da53cfdc758adad)</span></li>
<li>src/core/CMakeLists.txt <span style="color: grey">(9bc9a1c1a995f488185dfd19ef25bcc1f9e8a483)</span></li>
<li>KF5EmoticonsConfig.cmake.in <span style="color: grey">(9b0efbc99cfed73c13e49c940cd5607afba85f07)</span></li>
<li>CMakeLists.txt <span style="color: grey">(a48d111c59aa42d5b0b85aa959e5cf10e7b974b0)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115404/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>