Transitive dependency checks
Aurélien Gâteau
agateau at kde.org
Thu Jan 30 16:12:26 UTC 2014
On Wed, Jan 29, 2014, at 9:35, Alex Merry wrote:
> On 29/01/14 17:29, Michael Palimaka wrote:
> > Hi,
> >
> > In a some (not all) tier 3 frameworks, we check for transitive dependencies:
> >
> > #NOTE: here the dependencies of dependencies are displayed as well, this
> > shouldn't be needed
> > #after cmake 3.0.0 is released
> > find_package(...)
> >
> > I think this is no longer needed since we ship CMake config files for
> > each framework which pull in the required dependencies, and a number of
> > frameworks already omit the transitive checks and work fine.
> >
> > I'd like to start sending review requests to clean this all up unless
> > anyone thinks this is not correct.
>
> The issue, as I recall, was the *private* dependencies - ie: those not
> listed in the Config.cmake file. I'm not sure exactly what issue it
> caused, though, as I never encountered any problems. I wouldn't have
> thought that dynamic linking would produce any problems anyway; maybe
> static linking? Or Windows?
The issue only occurred with CMake 2.8.12 when building kdelibs as a
whole. It is no longer a problem now that the repositories have been
split. Therefore, I think you can go on and remove those dependencies.
Aurélien
More information about the Kde-frameworks-devel
mailing list