Transitive dependency checks

[Michael Palimaka]

On 01/30/2014 04:35 AM, Alex Merry wrote:
> On 29/01/14 17:29, Michael Palimaka wrote:
>> Hi,
>>
>> In a some (not all) tier 3 frameworks, we check for transitive dependencies:
>>
>> #NOTE: here the dependencies of dependencies are displayed as well, this
>> shouldn't be needed
>> #after cmake 3.0.0 is released
>> find_package(...)
>>
>> I think this is no longer needed since we ship CMake config files for
>> each framework which pull in the required dependencies, and a number of
>> frameworks already omit the transitive checks and work fine.
>>
>> I'd like to start sending review requests to clean this all up unless
>> anyone thinks this is not correct.
> 
> The issue, as I recall, was the *private* dependencies - ie: those not
> listed in the Config.cmake file.  I'm not sure exactly what issue it
> caused, though, as I never encountered any problems.  I wouldn't have
> thought that dynamic linking would produce any problems anyway; maybe
> static linking?  Or Windows?
> 
> Alex
> 

That makes a bit more sense, but I didn't run into that yet.

For example in kemoticons, it has normal dependencies on karchive and
kservice, with transitive dependencies on kcoreaddons, kdbusaddons, and
ki18n. Those transitive dependencies are then found anyway by
KF5ServiceConfig.cmake.

So I think it would be safe to drop the checks in this case at least.