Review Request 115380: Find QtGui when being consumed

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115380/#review48538
-----------------------------------------------------------


Then Qt5Core should go, it's a dependency of Qt5Gui and it will be searched for already.

- Aleix Pol Gonzalez


On Jan. 29, 2014, 2:53 p.m., Michael Palimaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115380/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2014, 2:53 p.m.)
> 
> 
> Review request for KDE Frameworks and Martin Gräßlin.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> -------
> 
> QtGui is exported in the public link interface, so linking of a consumer will fail if that consumer does not happen to use QtGui.
> 
> 
> Diffs
> -----
> 
>   KF5WindowSystemConfig.cmake.in 318df19071b57138126607d0ed908feec75102b8 
> 
> Diff: https://git.reviewboard.kde.org/r/115380/diff/
> 
> 
> Testing
> -------
> 
> Consumer kcrash builds when its QtGui checks are removed (it doesn't actually use them).
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140129/4cf69ef0/attachment.html>