Review Request 115380: Find QtGui when being consumed
Martin Gräßlin
mgraesslin at kde.org
Wed Jan 29 14:58:55 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115380/#review48537
-----------------------------------------------------------
Ship it!
Ship It!
- Martin Gräßlin
On Jan. 29, 2014, 3:53 p.m., Michael Palimaka wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115380/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2014, 3:53 p.m.)
>
>
> Review request for KDE Frameworks and Martin Gräßlin.
>
>
> Repository: kwindowsystem
>
>
> Description
> -------
>
> QtGui is exported in the public link interface, so linking of a consumer will fail if that consumer does not happen to use QtGui.
>
>
> Diffs
> -----
>
> KF5WindowSystemConfig.cmake.in 318df19071b57138126607d0ed908feec75102b8
>
> Diff: https://git.reviewboard.kde.org/r/115380/diff/
>
>
> Testing
> -------
>
> Consumer kcrash builds when its QtGui checks are removed (it doesn't actually use them).
>
>
> Thanks,
>
> Michael Palimaka
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140129/5622fbd9/attachment.html>
More information about the Kde-frameworks-devel
mailing list