Review Request 115359: rename dbus interface files and .desktop files in kio

[Jonathan Riddell]

> On Jan. 28, 2014, 4:16 p.m., Hrvoje Senjan wrote:
> > src/ioslaves/mailto/CMakeLists.txt, line 10
> > <https://git.reviewboard.kde.org/r/115359/diff/1/?file=240861#file240861line10>
> >
> >     Is renaming desktop file(s) really needed? If so, iirc one of tests in KService shall need adjusting.

well spotted, patch at https://git.reviewboard.kde.org/r/115361/
the test does have a comment "This could fail if it finds the kde4 kmailservice from /usr/share" which suggests it is needed


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115359/#review48486
-----------------------------------------------------------


On Jan. 28, 2014, 4:03 p.m., Jonathan Riddell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115359/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2014, 4:03 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> rename dbus interface files and .desktop files in kio to prevent clashes with kdelibs4 equivalents.  dbus interface itself remains the same.
> 
> 
> Diffs
> -----
> 
>   src/core/CMakeLists.txt 75ba28d 
>   src/ioslaves/http/kcookiejar/CMakeLists.txt b22ded4 
>   src/ioslaves/mailto/CMakeLists.txt acabf88 
>   src/ioslaves/mailto/kmailservice.desktop 03838a5 
>   src/ioslaves/mailto/kmailservice5.desktop PRE-CREATION 
>   src/ioslaves/telnet/CMakeLists.txt 70fea89 
>   src/ioslaves/telnet/ktelnetservice.desktop 052a9d3 
>   src/ioslaves/telnet/ktelnetservice5.desktop PRE-CREATION 
>   src/widgets/CMakeLists.txt 01b9483 
> 
> Diff: https://git.reviewboard.kde.org/r/115359/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140128/b90eda25/attachment.html>