<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115359/">https://git.reviewboard.kde.org/r/115359/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 28th, 2014, 4:16 p.m. UTC, <b>Hrvoje Senjan</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/115359/diff/1/?file=240861#file240861line10" style="color: black; font-weight: bold; text-decoration: underline;">src/ioslaves/mailto/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">10</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">install</span><span class="p">(</span><span class="s">PROGRAMS</span> <span class="s">kmailservice.desktop</span> <span class="s">DESTINATION</span> <span class="o">${</span><span class="nv">XDG_APPS_INSTALL_DIR</span><span class="o">}</span><span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">10</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">install</span><span class="p">(</span><span class="s">PROGRAMS</span> <span class="s">kmailservice<span class="hl">5</span>.desktop</span> <span class="s">DESTINATION</span> <span class="o">${</span><span class="nv">XDG_APPS_INSTALL_DIR</span><span class="o">}</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Is renaming desktop file(s) really needed? If so, iirc one of tests in KService shall need adjusting.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">well spotted, patch at https://git.reviewboard.kde.org/r/115361/
the test does have a comment "This could fail if it finds the kde4 kmailservice from /usr/share" which suggests it is needed
</pre>
<br />
<p>- Jonathan</p>
<br />
<p>On January 28th, 2014, 4:03 p.m. UTC, Jonathan Riddell wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and David Faure.</div>
<div>By Jonathan Riddell.</div>
<p style="color: grey;"><i>Updated Jan. 28, 2014, 4:03 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">rename dbus interface files and .desktop files in kio to prevent clashes with kdelibs4 equivalents. dbus interface itself remains the same.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/core/CMakeLists.txt <span style="color: grey">(75ba28d)</span></li>
<li>src/ioslaves/http/kcookiejar/CMakeLists.txt <span style="color: grey">(b22ded4)</span></li>
<li>src/ioslaves/mailto/CMakeLists.txt <span style="color: grey">(acabf88)</span></li>
<li>src/ioslaves/mailto/kmailservice.desktop <span style="color: grey">(03838a5)</span></li>
<li>src/ioslaves/mailto/kmailservice5.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/ioslaves/telnet/CMakeLists.txt <span style="color: grey">(70fea89)</span></li>
<li>src/ioslaves/telnet/ktelnetservice.desktop <span style="color: grey">(052a9d3)</span></li>
<li>src/ioslaves/telnet/ktelnetservice5.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/widgets/CMakeLists.txt <span style="color: grey">(01b9483)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115359/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>