Review Request 115248: Add runtime detection to KXMessages

Martin Gräßlin mgraesslin at kde.org
Mon Jan 27 08:43:28 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115248/
-----------------------------------------------------------

(Updated Jan. 27, 2014, 9:43 a.m.)


Review request for KDE Frameworks.


Changes
-------

* added warnings
* fixed access to d-ptr from static method *cough*


Repository: kwindowsystem


Description
-------

Add runtime detection to KXMessages

KXMessages should only be used if we are on platformX11. A compile time
check is not enough.


Diffs (updated)
-----

  src/kxmessages.cpp b409ef2114c18190188ba5503d2f357bd9336e76 

Diff: https://git.reviewboard.kde.org/r/115248/diff/


Testing
-------


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140127/23fca1e9/attachment.html>


More information about the Kde-frameworks-devel mailing list