Review Request 115248: Add runtime detection to KXMessages

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115248/#review48353
-----------------------------------------------------------



src/kxmessages.cpp
<https://git.reviewboard.kde.org/r/115248/#comment34193>

    Warning?



src/kxmessages.cpp
<https://git.reviewboard.kde.org/r/115248/#comment34194>

    Warning for the !d->valid case?


- Kevin Ottens


On Jan. 23, 2014, 9:03 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115248/
> -----------------------------------------------------------
> 
> (Updated Jan. 23, 2014, 9:03 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> -------
> 
> Add runtime detection to KXMessages
> 
> KXMessages should only be used if we are on platformX11. A compile time
> check is not enough.
> 
> 
> Diffs
> -----
> 
>   src/kxmessages.cpp b409ef2114c18190188ba5503d2f357bd9336e76 
> 
> Diff: https://git.reviewboard.kde.org/r/115248/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140127/2c9e4d7c/attachment-0001.html>