Review Request 115251: Add better runtime detection for X11 usage in KStartupInfo

Martin Gräßlin mgraesslin at kde.org
Mon Jan 27 07:31:24 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115251/
-----------------------------------------------------------

(Updated Jan. 27, 2014, 8:31 a.m.)


Review request for KDE Frameworks.


Changes
-------

improved as suggested


Repository: kwindowsystem


Description
-------

Add better runtime detection for X11 usage in KStartupInfo

Compile time checks for X11 is no longer sufficient. This adds a
runtime check to all the code paths which look dangerous if executed
on a non-X11 platform.


Diffs (updated)
-----

  src/kstartupinfo.cpp 5dbf47cb666fbed17c943491efe93e17f27d581e 

Diff: https://git.reviewboard.kde.org/r/115251/diff/


Testing
-------


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140127/2a954d20/attachment.html>


More information about the Kde-frameworks-devel mailing list