Review Request 115251: Add better runtime detection for X11 usage in KStartupInfo

[Àlex Fiestas]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115251/#review48141
-----------------------------------------------------------

Ship it!


The rest of the code is fine, +1 from me.


src/kstartupinfo.cpp
<https://git.reviewboard.kde.org/r/115251/#comment34047>

    Mayube will be better do a return early here?
    if (!X11Info::isPlatformX!!) {return} so we can avoid an extra indentation on all that code?


- Àlex Fiestas


On Jan. 23, 2014, 10:06 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115251/
> -----------------------------------------------------------
> 
> (Updated Jan. 23, 2014, 10:06 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> -------
> 
> Add better runtime detection for X11 usage in KStartupInfo
> 
> Compile time checks for X11 is no longer sufficient. This adds a
> runtime check to all the code paths which look dangerous if executed
> on a non-X11 platform.
> 
> 
> Diffs
> -----
> 
>   src/kstartupinfo.cpp 5dbf47cb666fbed17c943491efe93e17f27d581e 
> 
> Diff: https://git.reviewboard.kde.org/r/115251/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140123/2f0795cc/attachment-0001.html>