Review Request 115289: Search for LibIntl, not all platforms include it in libc

Alexander Richardson arichardson.kde at googlemail.com
Sun Jan 26 15:54:30 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115289/
-----------------------------------------------------------

(Updated Jan. 26, 2014, 4:54 p.m.)


Review request for KDE Frameworks and Chusslove Illich.


Changes
-------

check whether libintl needs a separate library by using check_symbol_exists


Summary (updated)
-----------------

Search for LibIntl, not all platforms include it in libc


Repository: ki18n


Description (updated)
-------

Search for LibIntl, not all platforms include it in libc

This is required on e.g. Windows, but also any other system that does
not use glibc as the default C library


Fix linking on MSVC by using KTRANSCRIPT_EXPORT


Diffs (updated)
-----

  cmake/FindLibIntl.cmake PRE-CREATION 
  src/CMakeLists.txt bfb7d793a8cea883378555368eeec7582e8f88b1 
  src/gettext.h 3d3c2733576b5d2b977c3360519636662caf18c5 
  src/kcatalog.cpp d337a50fb973e810e549671b60b2227db78d0628 
  src/ktranscript.cpp e0570f1cccabb8e3a59ff952eac2817081ec4e9e 
  CMakeLists.txt 165f8c84156ebdb5034424752cc5f80a5d70319c 

Diff: https://git.reviewboard.kde.org/r/115289/diff/


Testing
-------

Compiles on Windows, no change to Linux


Thanks,

Alexander Richardson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140126/09e00f30/attachment.html>


More information about the Kde-frameworks-devel mailing list