Review Request 115289: MSVC fix: Check for libintl.h and libintl.lib

[Alexander Richardson]

> On Jan. 24, 2014, 9:09 p.m., Alex Merry wrote:
> > cmake/FindLibIntl.cmake, line 26
> > <https://git.reviewboard.kde.org/r/115289/diff/2/?file=240465#file240465line26>
> >
> >     Why not check if a libintl symbol exists without linking against any special libraries?
> 
> Alexander Richardson wrote:
>     Would be better, but I have to admit that I lack the required CMake skills. What would I have to do for that check?
> 
> Alex Merry wrote:
>     I'm a bit rushed today, but you probably want to use http://www.cmake.org/cmake/help/v2.8.12/cmake.html#module:CheckCXXSymbolExists (quoting: "If the header files declare the symbol as a function or variable then the symbol must also be available for linking.").
>     
>     If it fails, you need to find libintl.
> 
> Alex Merry wrote:
>     If you get stuck, let me know, and I'll try to look at it tomorrow or Monday.

Didn't know about that, nice and clean solution


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115289/#review48246
-----------------------------------------------------------


On Jan. 24, 2014, 5:06 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115289/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2014, 5:06 p.m.)
> 
> 
> Review request for KDE Frameworks and Chusslove Illich.
> 
> 
> Repository: ki18n
> 
> 
> Description
> -------
> 
> MSVC fix: Check for libintl.h and libintl.lib
> 
> On MSVC we have libintl as a separate library and must therefore explicitly
> link to it. This is not required on linux since gettext is part of glibc.
> On Windows libintl.h is not always found in the default include path and
> has to be searched for.
> 
> Fix linking on MSVC by using KTRANSCRIPT_EXPORT
> 
> 
> Diffs
> -----
> 
>   src/ktranscript.cpp e0570f1cccabb8e3a59ff952eac2817081ec4e9e 
>   src/kcatalog.cpp d337a50fb973e810e549671b60b2227db78d0628 
>   src/gettext.h 3d3c2733576b5d2b977c3360519636662caf18c5 
>   src/CMakeLists.txt bfb7d793a8cea883378555368eeec7582e8f88b1 
>   cmake/FindLibIntl.cmake PRE-CREATION 
>   CMakeLists.txt 165f8c84156ebdb5034424752cc5f80a5d70319c 
> 
> Diff: https://git.reviewboard.kde.org/r/115289/diff/
> 
> 
> Testing
> -------
> 
> Compiles on Windows, no change to Linux
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140126/7c120adf/attachment.html>