Review Request 115065: kdoctools renames to add 5 namespace to prevent clashes with kdelibs4

[David Faure]

> On Jan. 19, 2014, 12:39 a.m., Luigi Toscano wrote:
> > The patch looks ago, I have two remarks:
> > - I think that kde5options should be kf5options (as it happened with kde4-config -> kf5-config)
> > 
> > - I'm not sure if the content of those manpages still applies. The special options described into those files were provided (and still provided through KDE4Support) by KCmdLineArgs, now replaced by the QCommandLineParser. I don't see those options to be defined into Frameworks, which means that {kde|kf}5options should be removed; are some of them provided by Qt directly? If not, also qt5config should disappear. Can someone from the kde-frameworks-devel list shed some light on this?

You are right, there's some cleanup to do, but also some regressions to fix.

* Some of these options are handled by Qt itself, like -caption (note: single dash!).
* Some of them have disappeared
* But for some it's a regression, like --nocrashhandler is still parsed by KCrash, but QCommandLineParser (when used by the app) barfs on it, since the option isn't defined. We need a method in KCrash.

We need to go through the full list and investigate each one; this work is necessary but not a blocker for this review request IMHO.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115065/#review47660
-----------------------------------------------------------


On Jan. 17, 2014, 4:48 p.m., Jonathan Riddell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115065/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2014, 4:48 p.m.)
> 
> 
> Review request for Documentation, KDE Frameworks, Luigi Toscano, and Scarlett Clark.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> -------
> 
> Rename man pages and checkXML tool to prevent clashes with kdelibs4
> credit should go to scarlett
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 74c7af5 
>   checkXML.in.cmake d7a57c7 
>   checkXML5.in.cmake PRE-CREATION 
>   docs/CMakeLists.txt 7e9612f 
>   docs/checkXML/CMakeLists.txt 7f8226c 
>   docs/checkXML/man-checkXML.1.docbook 2bfb3f3 
>   docs/checkXML5/CMakeLists.txt PRE-CREATION 
>   docs/checkXML5/man-checkXML5.1.docbook PRE-CREATION 
>   docs/kde5options/CMakeLists.txt PRE-CREATION 
>   docs/kde5options/man-kde5options.7.docbook PRE-CREATION 
>   docs/kdeoptions/CMakeLists.txt a91f451 
>   docs/kdeoptions/man-kdeoptions.7.docbook 7e62f41 
>   docs/qt5options/CMakeLists.txt PRE-CREATION 
>   docs/qt5options/man-qt5options.7.docbook PRE-CREATION 
>   docs/qtoptions/CMakeLists.txt f1dbb6c 
>   docs/qtoptions/man-qtoptions.7.docbook a00677a 
> 
> Diff: https://git.reviewboard.kde.org/r/115065/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140119/8378795d/attachment.html>