<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115065/">https://git.reviewboard.kde.org/r/115065/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 19th, 2014, 12:39 a.m. UTC, <b>Luigi Toscano</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The patch looks ago, I have two remarks:
- I think that kde5options should be kf5options (as it happened with kde4-config -> kf5-config)
- I'm not sure if the content of those manpages still applies. The special options described into those files were provided (and still provided through KDE4Support) by KCmdLineArgs, now replaced by the QCommandLineParser. I don't see those options to be defined into Frameworks, which means that {kde|kf}5options should be removed; are some of them provided by Qt directly? If not, also qt5config should disappear. Can someone from the kde-frameworks-devel list shed some light on this?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You are right, there's some cleanup to do, but also some regressions to fix.
* Some of these options are handled by Qt itself, like -caption (note: single dash!).
* Some of them have disappeared
* But for some it's a regression, like --nocrashhandler is still parsed by KCrash, but QCommandLineParser (when used by the app) barfs on it, since the option isn't defined. We need a method in KCrash.
We need to go through the full list and investigate each one; this work is necessary but not a blocker for this review request IMHO.</pre>
<br />
<p>- David</p>
<br />
<p>On January 17th, 2014, 4:48 p.m. UTC, Jonathan Riddell wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Documentation, KDE Frameworks, Luigi Toscano, and Scarlett Clark.</div>
<div>By Jonathan Riddell.</div>
<p style="color: grey;"><i>Updated Jan. 17, 2014, 4:48 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdoctools
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Rename man pages and checkXML tool to prevent clashes with kdelibs4
credit should go to scarlett</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(74c7af5)</span></li>
<li>checkXML.in.cmake <span style="color: grey">(d7a57c7)</span></li>
<li>checkXML5.in.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>docs/CMakeLists.txt <span style="color: grey">(7e9612f)</span></li>
<li>docs/checkXML/CMakeLists.txt <span style="color: grey">(7f8226c)</span></li>
<li>docs/checkXML/man-checkXML.1.docbook <span style="color: grey">(2bfb3f3)</span></li>
<li>docs/checkXML5/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>docs/checkXML5/man-checkXML5.1.docbook <span style="color: grey">(PRE-CREATION)</span></li>
<li>docs/kde5options/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>docs/kde5options/man-kde5options.7.docbook <span style="color: grey">(PRE-CREATION)</span></li>
<li>docs/kdeoptions/CMakeLists.txt <span style="color: grey">(a91f451)</span></li>
<li>docs/kdeoptions/man-kdeoptions.7.docbook <span style="color: grey">(7e62f41)</span></li>
<li>docs/qt5options/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>docs/qt5options/man-qt5options.7.docbook <span style="color: grey">(PRE-CREATION)</span></li>
<li>docs/qtoptions/CMakeLists.txt <span style="color: grey">(f1dbb6c)</span></li>
<li>docs/qtoptions/man-qtoptions.7.docbook <span style="color: grey">(a00677a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115065/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>