Review Request 114699: Use enums instead of ints in method types

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114699/
-----------------------------------------------------------

(Updated Jan. 16, 2014, 1:28 p.m.)


Review request for KDE Frameworks and David Faure.


Changes
-------

Add dfaure as a reviewer, since he originally said this would be a good idea.


Repository: kmediaplayer


Description
-------

Use enums instead of ints in method types.

This adds to the porting effort a little (but not in many places), but gives more type-safety.


Diffs
-----

  autotests/playertest.cpp 638e86fecf7eb418c802b1f46d04e864d8e161f6 
  autotests/testplayer.h 285da38fdf886ec8710e3a0d595ca20777426f86 
  autotests/viewtest.cpp 337ac3eef735dab7860bb6577c72fa33d3597068 
  src/kmediaplayer/player.h 57935bae537dba355b4c0cf2306dd6c993762661 
  src/kmediaplayer/player.cpp c0be47666094a12abc160538798efafe1e3e1fb0 
  src/kmediaplayer/view.h c3af06b51202b29f93ca0e3509ad41b8bbb91b0a 
  src/kmediaplayer/view.cpp 51e4c4ba5b16a4d7b90e57f78281fedb524eca54 

Diff: https://git.reviewboard.kde.org/r/114699/diff/


Testing
-------

Builds, tests run.


Thanks,

Alex Merry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140116/af4659e5/attachment.html>