<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114699/">https://git.reviewboard.kde.org/r/114699/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and David Faure.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated Jan. 16, 2014, 1:28 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add dfaure as a reviewer, since he originally said this would be a good idea.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kmediaplayer
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Use enums instead of ints in method types.
This adds to the porting effort a little (but not in many places), but gives more type-safety.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds, tests run.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/playertest.cpp <span style="color: grey">(638e86fecf7eb418c802b1f46d04e864d8e161f6)</span></li>
<li>autotests/testplayer.h <span style="color: grey">(285da38fdf886ec8710e3a0d595ca20777426f86)</span></li>
<li>autotests/viewtest.cpp <span style="color: grey">(337ac3eef735dab7860bb6577c72fa33d3597068)</span></li>
<li>src/kmediaplayer/player.h <span style="color: grey">(57935bae537dba355b4c0cf2306dd6c993762661)</span></li>
<li>src/kmediaplayer/player.cpp <span style="color: grey">(c0be47666094a12abc160538798efafe1e3e1fb0)</span></li>
<li>src/kmediaplayer/view.h <span style="color: grey">(c3af06b51202b29f93ca0e3509ad41b8bbb91b0a)</span></li>
<li>src/kmediaplayer/view.cpp <span style="color: grey">(51e4c4ba5b16a4d7b90e57f78281fedb524eca54)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114699/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>