Review Request 114971: Remove unused common files and do not install any of them

[Luigi Toscano]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114971/#review47472
-----------------------------------------------------------

Ship it!


> I don't think we should be installing the licenses either (certainly not to as generic a location as "share/LICENSES").
But maybe share/kf5/LICENSES (compared to share/kde4/apps/LICENSES).

Apart from this, I've nothing to object (also as it does not touch kdoctools). A quick check on the removed files (not copied into kdoctools) shows that they are not used at all everywhere.

- Luigi Toscano


On Jan. 15, 2014, 2:08 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114971/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2014, 2:08 p.m.)
> 
> 
> Review request for KDE Frameworks, Aurélien Gâteau and Luigi Toscano.
> 
> 
> Repository: kapidox
> 
> 
> Description
> -------
> 
> Remove unused common files and do not install any of them
> 
> Any files not actually used in apidox generation are removed (most of
> these actually belong in kdoctools, and should be installed from there).
> None of the common files are installed any more, because there is little
> point when we do not install the script that uses them.
> 
> 
> See https://git.reviewboard.kde.org/r/114969/
> 
> I don't think we should be installing the licenses either (certainly not to as generic a location as "share/LICENSES").
> 
> Incidentally, I plan on actually installing the scripts and everything once I've completed the frameworks port.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 02114642f0713e44f581e58c4d47192b4db2d238 
>   common/1.png a9ea29c1c4f52a90d62a1d0ca3586e4e82a46125 
>   common/10.png 00ba60fff1d08e0d04f1c28e7aa9565b4da56e5a 
>   common/2.png cc9762a8774fec901ef9ebe6efb8921c3c826d03 
>   common/3.png 7e0e4f185ebd534ae61e07323b75da7d00a65d01 
>   common/4.png fd80c9227489a5f613ba1f401434ff30b85453f9 
>   common/5.png cbad31966d92b6946818748df82f16b17cc38b3e 
>   common/6.png 20ddbd5becba7e0e0321ef161cb56c435fc022a1 
>   common/7.png 22fee5bc83c53be63341e17f1dd35e817202027e 
>   common/8.png a9adacfdab46cdc78c7779fe056fab30f7cfdeca 
>   common/9.png 56b36121d76a0cf474cc3d7d6dda79c8be6ac24a 
>   common/CMakeLists.txt 422862587499679d4bd4d10677b57e101b3ecb15 
>   common/artistic-license.html 2069b4ed07b67cb8d042926fce91bc1665fb9a07 
>   common/bottom-left.png a2d8a49093ab1840c3cb16de640bff6a7cf02763 
>   common/bottom-middle.png eba0bb056e3ffabafcbef1898cff7c73b3e0b01c 
>   common/bottom-right.png 01d5cd5055eccb5520726b3a7d56ac6df1022887 
>   common/bsd-license.html 422bb339fe00e62281f305e41b74e054f331e874 
>   common/fdl-license 4a0fe1c8deeb9861435d0aafa0c2096a6d624d2b 
>   common/fdl-license.html 9ce378a303567c9c8954638a02267fe0dd6bd775 
>   common/fdl-notice.html 862f09e7b3ac5dab09dc9c7ce805ff9cef1f496a 
>   common/gpl-license 93796b60a25f0174448a03d438d270fca49ae4ab 
>   common/gpl-license.html 26ae3af1f0cccbb6d30daf7128bad78d974d7926 
>   common/kde-default.css 24ef928201896a9d42b706f3edc7525882c33751 
>   common/kde-docs.css 12291a4c6ec5698d4b55fe644a3d053a2acefc49 
>   common/kde-localised.css.template abcd1ec916a6ebd610fdb5ae8b87699b8d301324 
>   common/kde_logo.png 336bfd858aa2d5b6146013eaa8bc45f0f7eca9c4 
>   common/kde_logo_bg.png 6cf47f17d794dadfa7f1ea1dca8fbea00fdc3649 
>   common/kmenu.png ff077c225a2af4c5b3e809c3a7cc1c1c203f8790 
>   common/lgpl-license ec47efc0608776917d0a5e4c33c6621c2a48278e 
>   common/lgpl-license.html 343576dfb5d869a7c2e14507f8bbbfe160ae937d 
>   common/mainfooter.html b12919329279b97d35fbb13b2d4fca685687396b 
>   common/mainheader.html 63fa04fc40a00235161bd45441f858f5d053ee45 
>   common/qpl-license.html 19a863bc52894fcf7337b5d805b7e2ae76fe69fb 
>   common/top-left.png 22e3bc698902b6ecaedd9a0bc98b51bd0b1b88b9 
>   common/top-middle.png 280ee2e2892ffc6c6b59c69601187cec11ea8779 
>   common/top-right.png 02598bc1d723a3129c324f8e4fe34f27649671b1 
>   common/x11-license.html 444a27bec97c26688dbb87f60fd7fe6e99859762 
>   common/xml.dcl fed210309215a3c7a8f447d85bdd9bca12ba5916 
> 
> Diff: https://git.reviewboard.kde.org/r/114971/diff/
> 
> 
> Testing
> -------
> 
> It still configures and installs (what little it does install).
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140115/91a7b0a2/attachment.html>