<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114971/">https://git.reviewboard.kde.org/r/114971/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">> I don't think we should be installing the licenses either (certainly not to as generic a location as "share/LICENSES").
But maybe share/kf5/LICENSES (compared to share/kde4/apps/LICENSES).
Apart from this, I've nothing to object (also as it does not touch kdoctools). A quick check on the removed files (not copied into kdoctools) shows that they are not used at all everywhere.</pre>
<br />
<p>- Luigi Toscano</p>
<br />
<p>On January 15th, 2014, 2:08 p.m. UTC, Alex Merry wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks, Aurélien Gâteau and Luigi Toscano.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated Jan. 15, 2014, 2:08 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kapidox
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Remove unused common files and do not install any of them
Any files not actually used in apidox generation are removed (most of
these actually belong in kdoctools, and should be installed from there).
None of the common files are installed any more, because there is little
point when we do not install the script that uses them.
See https://git.reviewboard.kde.org/r/114969/
I don't think we should be installing the licenses either (certainly not to as generic a location as "share/LICENSES").
Incidentally, I plan on actually installing the scripts and everything once I've completed the frameworks port.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It still configures and installs (what little it does install).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(02114642f0713e44f581e58c4d47192b4db2d238)</span></li>
<li>common/1.png <span style="color: grey">(a9ea29c1c4f52a90d62a1d0ca3586e4e82a46125)</span></li>
<li>common/10.png <span style="color: grey">(00ba60fff1d08e0d04f1c28e7aa9565b4da56e5a)</span></li>
<li>common/2.png <span style="color: grey">(cc9762a8774fec901ef9ebe6efb8921c3c826d03)</span></li>
<li>common/3.png <span style="color: grey">(7e0e4f185ebd534ae61e07323b75da7d00a65d01)</span></li>
<li>common/4.png <span style="color: grey">(fd80c9227489a5f613ba1f401434ff30b85453f9)</span></li>
<li>common/5.png <span style="color: grey">(cbad31966d92b6946818748df82f16b17cc38b3e)</span></li>
<li>common/6.png <span style="color: grey">(20ddbd5becba7e0e0321ef161cb56c435fc022a1)</span></li>
<li>common/7.png <span style="color: grey">(22fee5bc83c53be63341e17f1dd35e817202027e)</span></li>
<li>common/8.png <span style="color: grey">(a9adacfdab46cdc78c7779fe056fab30f7cfdeca)</span></li>
<li>common/9.png <span style="color: grey">(56b36121d76a0cf474cc3d7d6dda79c8be6ac24a)</span></li>
<li>common/CMakeLists.txt <span style="color: grey">(422862587499679d4bd4d10677b57e101b3ecb15)</span></li>
<li>common/artistic-license.html <span style="color: grey">(2069b4ed07b67cb8d042926fce91bc1665fb9a07)</span></li>
<li>common/bottom-left.png <span style="color: grey">(a2d8a49093ab1840c3cb16de640bff6a7cf02763)</span></li>
<li>common/bottom-middle.png <span style="color: grey">(eba0bb056e3ffabafcbef1898cff7c73b3e0b01c)</span></li>
<li>common/bottom-right.png <span style="color: grey">(01d5cd5055eccb5520726b3a7d56ac6df1022887)</span></li>
<li>common/bsd-license.html <span style="color: grey">(422bb339fe00e62281f305e41b74e054f331e874)</span></li>
<li>common/fdl-license <span style="color: grey">(4a0fe1c8deeb9861435d0aafa0c2096a6d624d2b)</span></li>
<li>common/fdl-license.html <span style="color: grey">(9ce378a303567c9c8954638a02267fe0dd6bd775)</span></li>
<li>common/fdl-notice.html <span style="color: grey">(862f09e7b3ac5dab09dc9c7ce805ff9cef1f496a)</span></li>
<li>common/gpl-license <span style="color: grey">(93796b60a25f0174448a03d438d270fca49ae4ab)</span></li>
<li>common/gpl-license.html <span style="color: grey">(26ae3af1f0cccbb6d30daf7128bad78d974d7926)</span></li>
<li>common/kde-default.css <span style="color: grey">(24ef928201896a9d42b706f3edc7525882c33751)</span></li>
<li>common/kde-docs.css <span style="color: grey">(12291a4c6ec5698d4b55fe644a3d053a2acefc49)</span></li>
<li>common/kde-localised.css.template <span style="color: grey">(abcd1ec916a6ebd610fdb5ae8b87699b8d301324)</span></li>
<li>common/kde_logo.png <span style="color: grey">(336bfd858aa2d5b6146013eaa8bc45f0f7eca9c4)</span></li>
<li>common/kde_logo_bg.png <span style="color: grey">(6cf47f17d794dadfa7f1ea1dca8fbea00fdc3649)</span></li>
<li>common/kmenu.png <span style="color: grey">(ff077c225a2af4c5b3e809c3a7cc1c1c203f8790)</span></li>
<li>common/lgpl-license <span style="color: grey">(ec47efc0608776917d0a5e4c33c6621c2a48278e)</span></li>
<li>common/lgpl-license.html <span style="color: grey">(343576dfb5d869a7c2e14507f8bbbfe160ae937d)</span></li>
<li>common/mainfooter.html <span style="color: grey">(b12919329279b97d35fbb13b2d4fca685687396b)</span></li>
<li>common/mainheader.html <span style="color: grey">(63fa04fc40a00235161bd45441f858f5d053ee45)</span></li>
<li>common/qpl-license.html <span style="color: grey">(19a863bc52894fcf7337b5d805b7e2ae76fe69fb)</span></li>
<li>common/top-left.png <span style="color: grey">(22e3bc698902b6ecaedd9a0bc98b51bd0b1b88b9)</span></li>
<li>common/top-middle.png <span style="color: grey">(280ee2e2892ffc6c6b59c69601187cec11ea8779)</span></li>
<li>common/top-right.png <span style="color: grey">(02598bc1d723a3129c324f8e4fe34f27649671b1)</span></li>
<li>common/x11-license.html <span style="color: grey">(444a27bec97c26688dbb87f60fd7fe6e99859762)</span></li>
<li>common/xml.dcl <span style="color: grey">(fed210309215a3c7a8f447d85bdd9bca12ba5916)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114971/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>