Review Request 114990: removing kde4 references from kauth

[Siddharth Sharma]

so basically of all yesterdays review requests, were to know if things
would change over there or not. did not replaced everything with kde4 ->
kde5



On Mon, Jan 13, 2014 at 5:39 PM, Alex Merry <kde at randomguy3.me.uk> wrote:

>    This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114990/
>    src/kauthactionreply.h<https://git.reviewboard.kde.org/r/114990/diff/1/?file=233880#file233880line157> (Diff
> revision 1)    157
>
>  kde4_add_executable(<helper_target> your sources...)
>
> 157
>
>  kde5_add_executable(<helper_target> your sources...)
>
>   There is no such thing as kde5_add_executable().
>
> Please have a look through http://community.kde.org/Frameworks/Porting_Notes for how the changes should actually be made.  In particular, the first section (Build System) says how CMake calls are changed.  In particular, there are *NO* cmake macros starting "kde5_".
>
>
>    src/kauthactionreply.h<https://git.reviewboard.kde.org/r/114990/diff/1/?file=233880#file233880line173> (Diff
> revision 1)    173
>
>  kde4_install_auth_actions(<helper_id> <actions definition file>)
>
> 173
>
>  kde5_install_auth_actions(<helper_id> <actions definition file>)
>
>   I'm sure no such macro exists.  Have a look in kauth/cmake/KF5AuthMacros.cmake for what it should become.
>
>
> - Alex Merry
>
> On January 12th, 2014, 8:12 p.m. UTC, Siddharth Sharma wrote:
>   Review request for KDE Frameworks.
> By Siddharth Sharma.
>
> *Updated Jan. 12, 2014, 8:12 p.m.*
>  *Repository: * kauth
> Description
>
> removing kde4 references from kauth
>
>   Testing
>
> none
>
>   Diffs
>
>    - src/kauthactionreply.h (a7d2020)
>
> View Diff <https://git.reviewboard.kde.org/r/114990/diff/>
>



-- 
Skrooge, a personal finances manager powered by KDE 4.x
http://skrooge.org
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140113/390f0cd6/attachment.html>