<div dir="ltr">so basically of all yesterdays review requests, were to know if things would change over there or not. did not replaced everything with kde4 -> kde5<div><br></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">
On Mon, Jan 13, 2014 at 5:39 PM, Alex Merry <span dir="ltr"><<a href="mailto:kde@randomguy3.me.uk" target="_blank">kde@randomguy3.me.uk</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
<div style="font-family:Verdana,Arial,Helvetica,Sans-Serif"><div class="im">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border:1px #c9c399 solid">
<tbody><tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114990/" target="_blank">https://git.reviewboard.kde.org/r/114990/</a>
</td>
</tr>
</tbody></table>
<br>
</div><div>
<table width="100%" border="0" bgcolor="white">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom:1px solid #c0c0c0;font-size:9pt;padding:4px 8px;text-align:left">
<a href="https://git.reviewboard.kde.org/r/114990/diff/1/?file=233880#file233880line157" style="text-decoration:underline;font-weight:bold" target="_blank">src/kauthactionreply.h</a>
<span style="font-weight:normal">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right:1px solid #c0c0c0" align="right"><font>157</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size:8pt;line-height:140%;margin:0"><span> kde<span>4</span>_add_executable(<helper_target> your sources...)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left:1px solid #c0c0c0;border-right:1px solid #c0c0c0" align="right"><font>157</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size:8pt;line-height:140%;margin:0"><span> kde<span>5</span>_add_executable(<helper_target> your sources...)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left:2em;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">There is no such thing as kde5_add_executable().
Please have a look through <a href="http://community.kde.org/Frameworks/Porting_Notes" target="_blank">http://community.kde.org/Frameworks/Porting_Notes</a> for how the changes should actually be made. In particular, the first section (Build System) says how CMake calls are changed. In particular, there are *NO* cmake macros starting "kde5_".</pre>
</div>
<br>
<div>
<table width="100%" border="0" bgcolor="white">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom:1px solid #c0c0c0;font-size:9pt;padding:4px 8px;text-align:left">
<a href="https://git.reviewboard.kde.org/r/114990/diff/1/?file=233880#file233880line173" style="text-decoration:underline;font-weight:bold" target="_blank">src/kauthactionreply.h</a>
<span style="font-weight:normal">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right:1px solid #c0c0c0" align="right"><font>173</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size:8pt;line-height:140%;margin:0"><span> kde<span>4</span>_install_auth_actions(<helper_id> <actions definition file>)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left:1px solid #c0c0c0;border-right:1px solid #c0c0c0" align="right"><font>173</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size:8pt;line-height:140%;margin:0"><span> kde<span>5</span>_install_auth_actions(<helper_id> <actions definition file>)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left:2em;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">I'm sure no such macro exists. Have a look in kauth/cmake/KF5AuthMacros.cmake for what it should become.</pre>
</div>
<br>
<p>- Alex Merry</p><div class="im">
<br>
<p>On January 12th, 2014, 8:12 p.m. UTC, Siddharth Sharma wrote:</p>
</div><table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image:url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png');background-repeat:repeat-x;border:1px black solid">
<tbody><tr>
<td><div class="im">
<div>Review request for KDE Frameworks.</div>
<div>By Siddharth Sharma.</div>
</div><p style="color:grey"><i>Updated Jan. 12, 2014, 8:12 p.m.</i></p><div class="im">
<div style="margin-top:1.5em">
<b style="color:#575012;font-size:10pt">Repository: </b>
kauth
</div>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border:1px solid #b8b5a0">
<tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">removing kde4 references from kauth</pre>
</td>
</tr>
</tbody></table>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border:1px solid #b8b5a0">
<tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">none</pre>
</td>
</tr>
</tbody></table>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Diffs </h1>
<ul style="margin-left:3em;padding-left:0">
<li>src/kauthactionreply.h <span style="color:grey">(a7d2020)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114990/diff/" style="margin-left:3em" target="_blank">View Diff</a></p>
</div></td>
</tr>
</tbody></table>
</div>
</div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br>Skrooge, a personal finances manager powered by KDE 4.x <br><a href="http://skrooge.org">http://skrooge.org</a>
</div>