Review Request 114988: Fix PREFIX parameter to ecm_generate_headers to match namespace KNS3
Friedrich W. H. Kossebau
kossebau at kde.org
Sun Jan 12 20:15:08 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114988/
-----------------------------------------------------------
Review request for KDE Frameworks, Aleix Pol Gonzalez and David Faure.
Repository: knewstuff
Description
-------
Currently the KNewStuff CamelCase forwarding headers are installed in [...]/include/KF5/KNewStuff3/knewstuff3
Which seems wrong, at least does not follow the pattern seen with the other namespaced modules. And breaks all existing #includes if the build does not use KDE4Support with its variants of the CamelCase forwarding headers.
Attached patch changes the PREFIX parameter to ecm_generate_headers from knewstuff3 to KNS3, so that the prefix matches the namespace of the classes in the module.
Diffs
-----
src/CMakeLists.txt 05cd500
Diff: https://git.reviewboard.kde.org/r/114988/diff/
Testing
-------
Applied and run make install: CamelCase includes are installed in [...]/include/KF5/KNewStuff3/KNS3 directory, code which #includes KNS3/* without KDE4Support builds.
Thanks,
Friedrich W. H. Kossebau
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140112/4e6dfe6c/attachment.html>
More information about the Kde-frameworks-devel
mailing list