Forwarding headers for ThreadWeaver

Mirko Boehm mirko at kde.org
Wed Jan 1 17:27:36 UTC 2014


Hi, 

On 01 Jan 2014, at 17:26 , David Faure <faure at kde.org> wrote:

> I'm converting all frameworks to ecm_generate_headers, which creates
> Framework/File forwarding headers for framework/file.h headers.
> 
> But ThreadWeaver creates an issue: it has File.h headers (titlecase),
> to be included like Weaver/Job.h
> 
> Shall we leave it as is then?
> Or convert it to weaver/job.h (lowercase) and Weaver/Job?

Both are fine with me. It should be done the same way as with the other modules. Which way is the official one?

> Or weaver/Job.h and Weaver/Job? But ecm_generate_header doesn't support non-
> lowercase headers so I'm not sure how to do that.
> 
> KDE4 had threadweaver/Job.h and ThreadWeaver/Job.
> 
> Why was the "Thread" word been removed?

I cannot say, I did not change it (at least not purposefully, maybe this is a side effect of changes in the build system). The Weaver/ directory was always the subfolder in the source directory, and threadweaver/ was used when installing. 

Since I was sick most of December, I am not completely done with the final touches for the release. I get back home on the 3rd, and will finish the last items on the TODO list on the 4th. Since this includes a few final class name changes, it needs to be synced with the followup changes in Plasma (nothing big). So from my point of view, ThreadWeaver should be ready early week 2. 

We are not having the threadweaver/ and ThreadWeaver/ directories in the same folder, right? Because that would not work on either OSX nor Windows (stating the obvious, I think). 

Happy new year, guys and girls! 2014 will certainly be the year of the Linux desktop!

Mirko.
-- 
Mirko Boehm | mirko at kde.org | KDE e.V.
FSFE Fellow, FSFE Team Germany
Qt Certified Specialist and Trainer






More information about the Kde-frameworks-devel mailing list