Review Request 115710: Hide private methods and slots behind the d-pointer in KHistoryComboBox

[David Gil Oliva]

> On Feb. 27, 2014, 8:09 p.m., David Faure wrote:
> > src/khistorycombobox.cpp, line 123
> > <https://git.reviewboard.kde.org/r/115710/diff/3/?file=246152#file246152line123>
> >
> >     q->connect is a strange way to call a static method. QObject::connect would be usual (if a bit more verbose).

IMHO, it isn't actually so strange:

Instead of

QObject::connect(sender, SIGNAL, receiver, SLOT);

it becomes

receiver->connect(sender, SIGNAL, SLOT);

http://qt-project.org/doc/qt-5/qobject.html#connect-3

Am I right?


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115710/#review51125
-----------------------------------------------------------


On Feb. 25, 2014, 10:50 p.m., David Gil Oliva wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115710/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2014, 10:50 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcompletion
> 
> 
> Description
> -------
> 
> Hide private methods and slots behind the d-pointer in KHistoryComboBox
> 
> Also:
> -Remove header not used
> 
> 
> Diffs
> -----
> 
>   autotests/kcombobox_unittest.cpp 49ef721 
>   src/khistorycombobox.h 3667eb4 
>   src/khistorycombobox.cpp 6f81dda 
> 
> Diff: https://git.reviewboard.kde.org/r/115710/diff/
> 
> 
> Testing
> -------
> 
> It builds. Tests pass.
> 
> 
> Thanks,
> 
> David Gil Oliva
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140227/9e982814/attachment.html>